Exporter README, receiver README updates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moh-osman3
reviewed
Aug 30, 2023
Comment on lines
146
to
147
| - `recevier_recv`: uncompressed bytes received, prior to compression | ||
| - `recevier_recv_wire`: compressed bytes received, on the wire. |
There was a problem hiding this comment.
s/recevier_recv/receiver_recv
s/recevier_recv_wire/receiver_recv_wire
Comment on lines
94
to
95
| - `disabled`: disables use of Arrow, causing the exporter to use standard OTLP | ||
| - `disable_downgrade`: prevents this exporter from using standard OTLP |
There was a problem hiding this comment.
Can we mention what the default value is for these settings?
|
@moh-osman3 FYI I observed one local test flake on |
jmacd
added a commit
that referenced
this pull request
Aug 31, 2023
Here at Lightstep we think that round_robin is a reasonably good default load balancer for OTel Arrow, while `pick_first` is what we get without setting something in this field. `pick_first` is not a reasonably good default load balancer for OTel Arrow. This change was documented in #29 already. Fixes #32.
jmacd
pushed a commit
that referenced
this pull request
Aug 31, 2023
After merging #24, unit tests for otelarrowreceiver were failing and I did not catch that. This PR fixes the unit tests by adding in support for an extra call to Send() the receiver will do (with arrowpb.StatusCode_STREAM_SHUTDOWN), to signal shutdown to the client. Addresses #29 (comment)
Merged
jmacd
added a commit
that referenced
this pull request
Aug 31, 2023
Release v0.3.0 includes: - #24 - #29 - #30 - #36 This release includes a BREAKING CHANGE 🛑 🛑 🛑 🛑 🛑. We do not anticipate another of these, it merely renames/enumbers status codes to match the gRPC status code numbering scheme. However, since status code 0 stays the same, it will result in unusual looking errors but should be safe to deploy the receivers first. Their CANCELED (i.e., SERVER_SHUTDOWN) will read as UNAVAILABLE, etc. See #27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flushes out the exporter README and makes a few corresponding fixes to the receiver README.